Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align validation with Logcollector API's socket Field Update #153

Merged
merged 1 commit into from May 13, 2024

Conversation

juliancnn
Copy link
Member

@juliancnn juliancnn commented May 2, 2024

Closes #152

Description

This pull request updates the Wazuh QA Integration Framework to reflect recent changes in the Logcollector configuration API, specifically adapting the validation of the API response to accommodate the renaming of the target field to socket. This change was introduced in the Wazuh core by PR wazuh/wazuh#17664 to enhance clarity in the configuration settings.

Modifications

  • Validation Script Updates:
    • The validation checks within the QA Integration Framework have been updated to replace references from target to socket. This ensures that our integration tests are consistent with the latest API specifications.

Goals

  • To ensure the QA Integration Framework accurately reflects the changes made to the Logcollector configuration API.
  • To maintain the reliability and accuracy of our integration tests following updates to the Wazuh core.

Testing Performed

  • Regression Tests: Conducted to ensure that the updated validation logic integrates smoothly without causing any disruptions in the existing test suite.
  • Validation Accuracy: Checked to confirm that the socket field is correctly identified and validated against expected values in the API responses.

Impact

These updates are essential for keeping the QA Integration Framework in sync with the latest developments in the Wazuh core, specifically ensuring that changes to the API are adequately reflected in our testing procedures.

Additional Notes

The changes introduced in this PR are minor but crucial for the ongoing alignment of our testing framework with the core application. Continuous monitoring will be required post-implementation to ensure that integration tests perform as expected without any issues.

@juliancnn juliancnn requested review from Nicogp and JcabreraC May 2, 2024 15:34
@juliancnn juliancnn self-assigned this May 2, 2024
@juliancnn juliancnn linked an issue May 2, 2024 that may be closed by this pull request
2 tasks
@juliancnn juliancnn requested a review from TomasTurina May 2, 2024 15:37
Copy link
Member

@JcabreraC JcabreraC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@juliancnn juliancnn changed the title Update QA Framework to Align with Logcollector API Changes Align QA Framework Validation with Logcollector API's socket Field Update May 2, 2024
@juliancnn juliancnn changed the title Align QA Framework Validation with Logcollector API's socket Field Update Align validation with Logcollector API's socket Field Update May 2, 2024
@JcabreraC JcabreraC merged commit 04a211f into 4.9.0 May 13, 2024
@TomasTurina TomasTurina deleted the fix/17662-fix-socket-conf-not--displayed branch May 15, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Validation for socket Field in Logcollector API
3 participants