Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Validation for socket Field in Logcollector API #152

Closed
2 tasks done
JcabreraC opened this issue May 2, 2024 · 0 comments · Fixed by #153
Closed
2 tasks done

Update Validation for socket Field in Logcollector API #152

JcabreraC opened this issue May 2, 2024 · 0 comments · Fixed by #153
Assignees
Labels

Comments

@JcabreraC
Copy link
Member

JcabreraC commented May 2, 2024

Description

This issue addresses the need to update the QA Integration Framework for Wazuh to accommodate recent changes made to the Logcollector configuration API. Specifically, this involves adapting the validation logic to align with the modifications introduced in Wazuh core by issue #17662 and implemented in PR wazuh/wazuh#17664.

Background

Recent enhancements to the Logcollector's configuration management have changed how socket configurations are represented in the API response. The field previously known as target has been renamed to socket. This change aims to clarify the configuration settings and improve consistency across the platform.

Task Description

The QA Integration Framework currently uses outdated field names when validating API responses related to Logcollector's configuration. To ensure that our integration tests remain reliable and accurate, it is necessary to update the framework to reflect these changes.

Required Changes

  • Update Field Validation: Modify the validation scripts in the QA Integration Framework to check for the socket field instead of the target field when parsing the API response for Logcollector's socket configuration.

Goals

  • Ensure that the QA Integration Framework accurately validates the updated API responses from Logcollector.
  • Maintain the integrity and reliability of our automated tests by aligning them with the latest developments in the Wazuh core.

Tasks

  • Replace the validation checks from target to socket in the relevant scripts.
  • Run regression tests to ensure that the updated validations work correctly with the new API responses.

Testing Criteria

  • Regression Testing: Perform regression tests to verify that the updated validation logic does not introduce any new issues or failures in existing tests.
  • Accuracy Verification: Ensure that the modified scripts correctly validate the socket field in the API responses, reflecting the changes made in PR wazuh/wazuh#17664.

Impact

This update is crucial for maintaining the accuracy of integration tests following changes to the Logcollector configuration API. By ensuring that our testing framework stays aligned with the core application's functionality, we can continue to guarantee the stability and reliability of Wazuh across releases.

Notes

It is essential to closely monitor the outcomes of the integration tests following this update to quickly address any potential discrepancies that may arise due to the changes in API response structures.

@juliancnn juliancnn linked a pull request May 2, 2024 that will close this issue
@juliancnn juliancnn changed the title Update Logcollector Configuration Validation to Reflect API Response Changes Update Validation in QA Integration Framework for socket Field in Logcollector API May 2, 2024
@juliancnn juliancnn changed the title Update Validation in QA Integration Framework for socket Field in Logcollector API Update Validation for socket Field in Logcollector API May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants