Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dh virtualenv test #91

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Dh virtualenv test #91

wants to merge 5 commits into from

Conversation

sopelj
Copy link

@sopelj sopelj commented Oct 25, 2023

No description provided.

@sopelj sopelj force-pushed the dh-virtualenv-test branch 2 times, most recently from 368c0dc to 679c3c0 Compare October 25, 2023 19:06
@wazo-platform wazo-platform deleted a comment from wazo-community-zuul bot Oct 25, 2023
@wazo-platform wazo-platform deleted a comment from wazo-community-zuul bot Oct 25, 2023
@wazo-community-zuul
Copy link
Contributor

Build succeeded.
https://zuul.wazo.community/zuul/t/local/buildset/75eb2581f1d64f8d8786098524f69722

✔️ tox-linters SUCCESS in 4m 59s
✔️ wazo-tox-py39 SUCCESS in 6m 16s
✔️ wazo-tox-integration-py39 SUCCESS in 4m 10s
✔️ debian-packaging-bullseye SUCCESS in 2m 57s

@wazo-community-zuul
Copy link
Contributor

Build succeeded.
https://zuul.wazo.community/zuul/t/local/buildset/8045dd19a2254decaff4042170dee3e2

✔️ tox-linters SUCCESS in 3m 43s
✔️ wazo-tox-py39 SUCCESS in 5m 12s
✔️ wazo-tox-integration-py39 SUCCESS in 4m 26s
✔️ debian-packaging-bullseye SUCCESS in 3m 04s

Copy link
Contributor

Build succeeded.
https://zuul.wazo.community/zuul/t/local/buildset/70d6227370a643dfa1fbdd075b7eaef2

✔️ tox-linters SUCCESS in 3m 45s
✔️ wazo-tox-py39 SUCCESS in 5m 07s
✔️ wazo-tox-integration-py39 SUCCESS in 4m 06s
✔️ debian-packaging-bullseye SUCCESS in 3m 06s

@sopelj
Copy link
Author

sopelj commented Dec 20, 2023

This is sort of a proof of concept, and should be tested a bit more before merging. However, it does build and install correctly and seems to work perfectly fine.

The versions could also be bumped if desired, but for now it is essentially the same as before, but the package contains its own versions of its dependencies instead of using system ones. And thus they should be updated to maintained versions and not rely on Debian's.

@sboily
Copy link
Member

sboily commented Dec 20, 2023

Have you tried with a plugin, is there is any impact to register an entrypoint from an external program with this changes?

@sopelj
Copy link
Author

sopelj commented Dec 20, 2023

Have you tried with a plugin, is there is any impact to register an entrypoint from an external program with this changes?

That's a good question! I have not tried with an external program. Do you have any examples we could test with? If it is installed system-wide it would probably not be detected as the default option is to not include system packages.

If it's something installed by a third party they could simply install it into the virtualenv for this service. If it's something we package, we might have to look into how sharing a virtualenv might work or changing path settings for package discovery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants