Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow autoprov devices discovery #90

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

BnLG
Copy link

@BnLG BnLG commented Jul 21, 2022

Hello,

When we provision devices using the Provision Extension method, there's no issue when stack is on local network, because all devices have a unique IP.
When devices are NATed, for example when stack is public, registering devices from a specific site using the Provision Extension method works for the very first device, then fails, as subsequent devices come with the same IP.

This PR then narrows devices discovery, limiting it to devices in autoprov status.
As a result, provisioning NATed devices from a specific site one by one, using the Provision Extension method, will work.

Many thanks 馃憤

Depends-On: wazo-platform/wazo-confd#272

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2022

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BnLG
Copy link
Author

BnLG commented Jul 21, 2022

Note that this PR depends on wazo-platform/wazo-confd#272.

@wazo-community-zuul
Copy link
Contributor

Build failed.

@BnLG
Copy link
Author

BnLG commented Jul 21, 2022

I would say tests are failing because wazo-platform/wazo-confd#272 is missing from the tests themselves.
Feel free to confirm Wazo team :)

@BnLG
Copy link
Author

BnLG commented Aug 16, 2022

Hi,
Any thoughts on this tiny (but helpful) PR ?
Many thanks 馃憤

@wazo-community-zuul
Copy link
Contributor

Build failed.

@wazo-community-zuul
Copy link
Contributor

This change depends on a change that failed to merge.

@bloom1
Copy link
Member

bloom1 commented Aug 30, 2022

recheck

@wazo-community-zuul
Copy link
Contributor

Build failed.

@wazo-community-zuul
Copy link
Contributor

Build succeeded.

@wazo-community-zuul
Copy link
Contributor

Build succeeded.

@BnLG
Copy link
Author

BnLG commented Sep 5, 2022

Does it look good for you @bloom1 ?
Many thanks 馃憤

@wazo-community-zuul
Copy link
Contributor

Build succeeded.

@BnLG
Copy link
Author

BnLG commented Oct 3, 2022

@bloom1, may I also ask you some news regarding this ?
Thank you very much 馃憤

to get a change to provision NATed ones
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2022

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wazo-community-zuul
Copy link
Contributor

Build succeeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants