-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Narrow autoprov devices discovery #90
base: master
Are you sure you want to change the base?
Conversation
Kudos, SonarCloud Quality Gate passed!聽 聽 0 Bugs No Coverage information |
Note that this PR depends on wazo-platform/wazo-confd#272. |
Build failed.
|
I would say tests are failing because wazo-platform/wazo-confd#272 is missing from the tests themselves. |
Hi, |
Build failed.
|
This change depends on a change that failed to merge. |
recheck |
Build failed.
|
Build succeeded.
|
Build succeeded.
|
Does it look good for you @bloom1 ? |
Build succeeded.
|
@bloom1, may I also ask you some news regarding this ? |
to get a change to provision NATed ones
Integration test
Kudos, SonarCloud Quality Gate passed!聽 聽 0 Bugs No Coverage information |
Build succeeded.
|
Hello,
When we provision devices using the Provision Extension method, there's no issue when stack is on local network, because all devices have a unique IP.
When devices are NATed, for example when stack is public, registering devices from a specific site using the Provision Extension method works for the very first device, then fails, as subsequent devices come with the same IP.
This PR then narrows devices discovery, limiting it to devices in autoprov status.
As a result, provisioning NATed devices from a specific site one by one, using the Provision Extension method, will work.
Many thanks 馃憤
Depends-On: wazo-platform/wazo-confd#272