Add support for deleting queues after flushing them #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an environment where we're trying to reset a queue by flushing it (e.g. tests), it can be desirable to also have the ability for the queue to be deleted. For example, if you'd like to create a new queue with different parameters, but the same name.
|
This change makes me a bit sad, as it's not behavior I'd expect to exist on a "flush" fn call (I'd rather have purging as part of the test infrastructure), but for what it is, it looks good. I would add a "deleting" log line, however. /approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an environment where we're trying to reset a queue by flushing it (e.g. tests), it can be desirable to also have the ability for the queue to be deleted. For example, if you'd like to create a new queue with different parameters, but the same name.