Update appguide.rst #439
Draft
Update appguide.rst #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify where to add apps to auto launch in sim. Add notes on auto launching the sim on changes.
There was a problem hiding this comment.
Please also squash into one patch and add a DCO signoff (see https://wasp-os.readthedocs.io/en/latest/contributing.html ).
| @@ -280,10 +280,13 @@ by swiping or using the Arrow keys to bring up the launcher and then clicking | |||
| on your application. | |||
|
|
|||
| The application can also be registered automatically when you load the | |||
| simulator if you add it to ``wasp/main.py``. Try adding lines 5 and 6 from | |||
| simulator if you add it to ``wasp/boards/simulator/main.pywasp/main.py``. Try adding lines 5 and 6 from | |||
There was a problem hiding this comment.
This change doens't look right.
| the above example into this file (between ``import wasp`` and | ||
| ``wasp.system.run()``). | ||
|
|
||
| You can use something like ``while inotifywait -e modify hello.py; do killall python3; nohup make sim 2>&1 & done`` to |
There was a problem hiding this comment.
Nice concept. However killall python3 is pretty brutal so I think it needs to be "Kill any existing simulator processes (and any other python3 interpretters that are currently running) and (re)launch..."
|
What's a good way to spot the simulator process more precisely? Pkill isn't much help?
--
†øღ
Sent from a super computer that fits in my pocket and is connected to the sum total of all human knowledge
…On 24 August 2023 21:29:56 BST, Daniel Thompson ***@***.***> wrote:
@daniel-thompson commented on this pull request.
Please also squash into one patch and add a DCO signoff (see https://wasp-os.readthedocs.io/en/latest/contributing.html ).
> @@ -280,10 +280,13 @@ by swiping or using the Arrow keys to bring up the launcher and then clicking
on your application.
The application can also be registered automatically when you load the
-simulator if you add it to ``wasp/main.py``. Try adding lines 5 and 6 from
+simulator if you add it to ``wasp/boards/simulator/main.pywasp/main.py``. Try adding lines 5 and 6 from
This change doens't look right.
> the above example into this file (between ``import wasp`` and
``wasp.system.run()``).
+You can use something like ``while inotifywait -e modify hello.py; do killall python3; nohup make sim 2>&1 & done`` to
Nice concept. However `killall python3` is pretty brutal so I think it needs to be "Kill any existing simulator processes (and any other python3 interpretters that are currently running) and (re)launch..."
--
Reply to this email directly or view it on GitHub:
#439 (review)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
It's better to use dedicated tools such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify where to add apps to auto launch in sim.
Add notes on auto launching the sim on changes.