Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new: add a lower brightness setting via PWM #389

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

new: add a lower brightness setting via PWM #389

wants to merge 2 commits into from

Conversation

thiswillbeyourgithub
Copy link
Contributor

@thiswillbeyourgithub thiswillbeyourgithub commented Jan 15, 2023 •
edited

Signed-off-by: thiswillbeyourgithub github@32mail.33mail.com

Inspired by #68 and related to #373

Edit: this might only work on the pinetime but I'm not confident modifying the files of watches I don't have around.

feat: allow less brightness levels
01a7504 
Signed-off-by: thiswillbeyourgithub <github@32mail.33mail.com>
@fgaz fgaz added enhancement New feature or request device:pinetime Specific to PineTime hardware labels Jan 15, 2023
@thiswillbeyourgithub
Copy link
Contributor Author

Well... Apparently when the watch vibrates once any time after boot, the watch then starts vibrating as soon as the screen turns off. And when woken up the vibration is at a different duty level. Permanently until reboot or another vibration is triggered.

When logged into the console I see that the different duty level of this permanent vibration are toggled when doing wasp.watch.backlight.pwm.init() and deinit()

I severely lack understanding of PWM so I'm afraid this is out of my reach.

@thiswillbeyourgithub thiswillbeyourgithub changed the title new: add a lower brightness setting via PWM BROKEN new: add a lower brightness setting via PWM Jan 15, 2023
@fgaz fgaz marked this pull request as draft January 15, 2023 18:19
@thiswillbeyourgithub thiswillbeyourgithub changed the title BROKEN new: add a lower brightness setting via PWM BROKEN_PLEASE_HELP new: add a lower brightness setting via PWM Apr 21, 2023
@thiswillbeyourgithub
fix: pwm was using the same id for motor and screen
d1944da 
Signed-off-by: thiswillbeyourgithub <26625900+thiswillbeyourgithub@users.noreply.github.com>
@thiswillbeyourgithub thiswillbeyourgithub changed the title BROKEN_PLEASE_HELP new: add a lower brightness setting via PWM new: add a lower brightness setting via PWM Oct 10, 2023
@fgaz fgaz marked this pull request as ready for review October 12, 2023 15:39
@fgaz
Copy link
Member

fgaz commented Oct 12, 2023

There is a merge conflict

@thiswillbeyourgithub
Copy link
Contributor Author

thiswillbeyourgithub commented Oct 12, 2023 •
edited

Yeah I ended up testing it on a fresh branch. Actually I don't really need this feature anymore so except if you tell me it's an actual benefit or power saver I think I might just close it. It was also a way for me to try to make pwm work and tinker with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-thompson daniel-thompson daniel-thompson left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
device:pinetime Specific to PineTime hardware enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thiswillbeyourgithub @fgaz @daniel-thompson