Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bidirectional notification clearing over gadget bridge #383

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

beardeddude
Copy link
Contributor

Currently clearing notifications on the watch leaves the notifications on the phone. Now that Gadgetbridge supports notification clearing we should keep the devices in sync so notification don't need to be cleared twice.

Features:

  • Clear notifications button now clears notifications on device as well

Other:

  • Moved send command function from music app to gadget bridge file for reuse between apps

Testing:

  • Tested using Pinetime and Gadgetbridge 0.72 (0.56+ should work)

Signed-off-by: Adam Blair adampblair@protonmail.com

* Clear notifications button now clears notifications on device as well

Signed-off-by: Adam Blair <adampblair@protonmail.com>
@beardeddude beardeddude force-pushed the bidirectional_notification_clearing branch from 4c69bc8 to 17e5be6 Compare March 19, 2023 19:02
@beardeddude
Copy link
Contributor Author

Conflicts resolved. Ready for review

@fgaz fgaz added the enhancement New feature or request label Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants