Quick timer enhancement #382
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beardeddude
force-pushed
the
quick_timer
branch
3 times, most recently
from
0485a77
to
1160945
Compare
I asked on #wasp-os:libera.chat and it looks like this is the blocker: #386 |
Features: * Added starting screen to timer app with quick timers Signed-off-by: Adam Blair <adampblair@protonmail.com>
beardeddude
force-pushed
the
quick_timer
branch
from
1160945
to
2136d85
Compare
|
Conflicts resolved. Ready for review |
fgaz
reviewed
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
I added quick timers to the timer app to make it faster to use. The values I chose should be the most common but I welcome input. If custom is selected the user is presented the same display as before and if a timer is stopped the app will return to the custom set screen with the original time reset (quick or custom) for fast re-use. To get back to the quick select screen the app would need to be closed while the timer is not running.
Testing:
Other thoughts:
I have no idea about the current release process but it would be awesome to see a newer release binary on github as the current one is really old.
Signed-off-by: Adam Blair adampblair@protonmail.com