Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: move Stopwatch library from widgets.py to apps/stopwatch.py #362

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thiswillbeyourgithub
Copy link
Contributor

Isn't it tidier?

@kLabz
Copy link
Contributor

kLabz commented Sep 21, 2022

It's also used in wasp/apps/sports.py though

thiswillbeyourgithub added 2 commits September 21, 2022 13:38
Signed-off-by: thiswillbeyourgithub <github@32mail.33mail.com>
Signed-off-by: thiswillbeyourgithub <github@32mail.33mail.com>
@thiswillbeyourgithub
Copy link
Contributor Author

In commit 18aa61 I also enabled hours/Minute conversion instead of just second display.

@kLabz omg I feel dumb. Well I'm closing this then. Thanks!

@thiswillbeyourgithub
Copy link
Contributor Author

Come to think of it, isn't it an indicator that having 2 apps for this is too much? I never used the sports app and am curious if people really find useful to see both the stopwatch and the step counter

@daniel-thompson
Copy link
Collaborator

Come to think of it, isn't it an indicator that having 2 apps for this is too much? I never used the sports app and am curious if people really find useful to see both the stopwatch and the step counter

The sports app doesn't show the daily step count, it starts from zero. The idea is you can set the Sports app running at the start of a run and when you get to the end you know how many strides and how long it took.

@thiswillbeyourgithub
Copy link
Contributor Author

That seems a bit specific too me and I would think it would be better to leave it in /apps instead of wasp/apps. Your call as usual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants