feat saved alarms 2 #350
Open
feat saved alarms 2 #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 17, 2022 13:00
Signed-off-by: thiswillbeyourgithub <github@32mail.33mail.com>
Signed-off-by: thiswillbeyourgithub <github@32mail.33mail.com>
fgaz
reviewed
Aug 17, 2022
Comment on lines
+104
to
+106
| except Exception as err: | ||
| wasp.system.switch(PagerApp("Error when reloading alarms: " | ||
| "'{}'".format(err))) |
There was a problem hiding this comment.
Will this trigger also the first time the app is run, when the file is not there yet?
There was a problem hiding this comment.
Yes. My personnal inclination is of course to pay attention to this kind of things but on waspos given that every line seems to count I felt that was a good compromise.
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quick fix after @fgaz 's late review (#344)