No longer validate Wasm module header in Module::new_unchecked
#1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1025 +/- ##
==========================================
+ Coverage 80.77% 80.79% +0.02%
==========================================
Files 269 269
Lines 24788 24802 +14
==========================================
+ Hits 20022 20040 +18
+ Misses 4766 4762 -4 ☔ View full report in Codecov by Sentry. |
Robbepop
changed the title
Module::new_unchecked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks showed that validation of the data section can be very costly for some Wasm binaries and furthermore the data section does strictly not belong to the Wasm module header. Therefore it makes sense to no longer validate it in header-only validation mode.