New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize data section parsing and storage #1024
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Active data segments now store all their bytes into a common buffer to avoid having many small allocations.
This reverts commit 1ff9249.
This leads to smaller indices which mades it possible to only store u32 instead of usize decreasing the size_of<DataSegment> by 8 bytes in total. Also applied rustfmt and added missing docs.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1024 +/- ##
==========================================
- Coverage 80.80% 80.77% -0.03%
==========================================
Files 269 269
Lines 24736 24786 +50
==========================================
+ Hits 19989 20022 +33
- Misses 4747 4764 +17 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks revealed that parsing and handling of data sections were a big contributor to the overall spent time for some benchmarks, such as
ffmpeg.wasm
. This is probably due to heap memory allocator pressure since all of its many data segments each allocated a bit of heap memory for their bytes.This PR bundles bytes of all active data segments into a single buffer reducing the overall memory consumption and pressure on the heap memory allocator.
Benchmarks show roughly 15% improvement for compiling
ffmpeg.wasm
in lazy compilation mode.