Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build dependent packages as needed #98

Merged
merged 1 commit into from Oct 8, 2019
Merged

Conversation

torch2424
Copy link

@torch2424 torch2424 commented Oct 4, 2019

  • Only build libraries that go up it's parent chain on changes
  • Introduce chokidar-cli to not run on initial watch
  • Parallelized building where I could 馃槃
  • Rust changes are just from building and running the lintes

Why isn't this super fast?

This is because of our options of bundling typescript 馃槩

  • First, I discovered what was causing slower build times was: Compilation very slow with TS v3.4聽ezolenko/rollup-plugin-typescript2#148
  • So then I tried downgrading typescript in the branch: faster-builds, but only got a very small improvement.
  • Then, I tried to avoid the plugin totally, and use babel. But babel did not have a good time transpiling Comlink, and it's build times were also only slightly faster. On the branch: babel-for-typescript
  • Lastly, I tried to revert back to Rollup's native watching. But rollup's bundle cache will conflict with rollup-plugin-typescript2's bundle chace, so it does not work 馃槩 On the branch: rollup-native-watching

Example

Screen Shot 2019-10-04 at 12 31 58 PM

@torch2424 torch2424 self-assigned this Oct 4, 2019
@torch2424 torch2424 merged commit 3dc34d1 into master Oct 8, 2019
@torch2424 torch2424 deleted the proper-lib-watching branch October 8, 2019 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants