Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow: Rename docker container #168

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

14sprouj
Copy link

@14sprouj 14sprouj commented Aug 4, 2023

Discord username (optional) please include so we can attribute you with our Contributor role (like so elvis#4747)

sproj003

Description of changes (updated or new workflows)

New workflow for renaming a docker container

arguments:
- name: old_container
description: The name of the old container
default_value: ~
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove the default value parameter, since the actual container names will be specific to each user.

Copy link
Member

@elviskahoro elviskahoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just have some minor feedback around removing the default value arguments.

@14sprouj thanks for contributing and let me know your discord username if you're in our server so I can add the right badges

default_value: ~
- name: new_container
description: The name of the new container
default_value: ~
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here!

I think we should remove the default value parameter, since the actual container names will be specific to each user.

@elviskahoro
Copy link
Member

Looks good. Just have some minor feedback around removing the default value arguments.

@14sprouj thanks for contributing and let me know your discord username if you're in our server so I can add the right badges

I see your discord name I'll check to see if the role has been already added

@elviskahoro elviskahoro enabled auto-merge (squash) February 12, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants