Random numbers for decentralized sequencer interactions #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppedziwiatr
reviewed
Nov 6, 2023
| } | ||
| const base64 = this._activeTx.random.replace(/-/g, '+').replace(/_/g, '/'); | ||
| const array = Uint8Array.from(atob(base64), c => c.charCodeAt(0)); | ||
| const bigInt = Buffer.from(array).readBigUInt64BE(); |
There was a problem hiding this comment.
please add
import { Buffer } from 'warp-isomorphic';
Buffer is nodejs specific and the above code might not work in browser.
There was a problem hiding this comment.
The import has been added.
| @@ -260,6 +280,9 @@ export class SWVrf { | |||
|
|
|||
| // returns a random value in a range from 1 to maxValue | |||
| randomInt(maxValue: number): number { | |||
There was a problem hiding this comment.
please mark as Deprecated and update the docs here https://docs.warp.cc/docs/sdk/advanced/vrf
There was a problem hiding this comment.
I have added comments with @deprecated. I will update all documentation related to the new sequencer as part of the task at warp-contracts/sequencer#85.
szynwelski
force-pushed
the
szynek/sequencer-client
branch
4 times, most recently
from
9acada5
to
3f81256
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.