Made it compatible with other devices #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the help of the refresh token (hopefully)
…per call of onTemporalEvent
… instead of 5KB. Ran out of background process space and this data, converted to a dictionary was even taking more space and was too big for the space left in the background process.
… of data instead of 5KB." This reverts commit 4775051.
…g code to free space" This reverts commit 6524842.
This reverts commit 7d6cc11.
This reverts commit 1c77cf8.
…to expire" This reverts commit ade7252.
…tation (I think). Stable now. Log verbosity decreased. Can almost keep an hour worth of output on the watch .TXT files themselves
…launch while the car is asleep, use its last known battery charge
…inside temperature
…e than just the battery stuff now
…Info when not selected, fix code that always display P and S using theme color. Added more watches by using a more recent SDK version.
- Corrected invalid value for Stress read from sensor, not Complications - For performance, ignore Tesla-Link Complications if we're told not to use them - Changed the logic for when the background process should run next
…or Temporal Event time triggering
… they can't use (Complications for this round)
…rom happening again
- Added a default custom Complication to launch when pressing anywhere that's it's not a field, indicator or goal configured as a complication. By Default, this field is set to "Flashlight" (new Widget I created), which if installed on the watch, will transform the screen into a flashlight with three intensity, with the launched one being the dimmest - Fixed a crash in onPress
AdrienChenu
reviewed
Sep 18, 2023
There was a problem hiding this comment.
Longitudes go from -180 to +180. This current check restrict the time zone east of Chicago and west of India (roughly).
The local city feature does not currently work for East Asia (China, Japan) or California for example.
Hopefully this change will fix this.
Thanks for considering it.
AdrienChenu
reviewed
Sep 18, 2023
There was a problem hiding this comment.
Longitudes go from -180 to +180. This current check restrict the time zone east of Chicago and west of India (roughly).
The local city feature does not currently work for East Asia (China, Japan) or California for example.
Hopefully this change will fix this.
Thanks for considering it.
|
Hi, I haven't had the time to look at it yet but should be able before the
end of the week.
Le lun. 18 sept. 2023, à 17 h 46, Adrien Chenu ***@***.***> a
écrit :
… ***@***.**** commented on this pull request.
Longitudes go from -180 to +180. This current check restrict the time zone
east of Chicago and west of India (roughly).
The local city feature does not currently work for East Asia (China,
Japan) or California for example.
Hopefully this change will fix this.
Thanks for considering it.
—
Reply to this email directly, view it on GitHub
<#209 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALYXESXLNTMTB5ETZDWHHT3X3C6LLANCNFSM5ESSMNUQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Thank you. No rush at all. I'm quite new to contributing to Github, I thought my comment was linked to the line of code when I wrote it, and I posted the same comment twice. Sorry. 😅 I managed to create a Pull Request that should hopefully fix it: SylvainGa#8 Feel free to reject if I did it wrong, and thanks again for making that watch face. It's the main one I use. |
Enable longitude west of Chicago and east of India
- Added Altitude as a Complication - Fixed bug in longitude typechecking for second time (thanks AdrienChenu)
- Fixed crash when complicationId is unexpectedly null - Added Battery as a complication (to launch the battery widget)
Found the cause for the crash at line 862. onPress caught exception PreviousOperationNotCompleteException Added try/catch around exitto calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.