Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to the post metadata component #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kimlaberinto
Copy link
Contributor

Stylistic choice. I thought it might be nice to have the tags visible/clickable for website visitors to see immediately. I added the post's tags (with a hashtag) to the post-metadata.html component. Tag icon is from FontAwesome.

From what I can see, this affects 2 locations. Two screenshots below.

Here is what it looks like on the pages widget on the homepage of the example website.
image

Here is what it looks like on the post webpage itself at the top. (The tags are also still at the bottom too.)
image

Feel free to reject if you don't like the look. No offense taken.

@wangchucheng
Copy link
Owner

The reason why I did not put tags on the top is that this may cause the top content to be too complicated and lose its simplicity. And I found that many websites (such as medium) also put tags at the bottom, so I ended up using this design.

What do you think about this? At the same time, if many Eureka users feel that this is a necessary modification, I might use it as an option. But at the moment I think keeping the top concise is a better choice as putting tags at the bottom is not an uncommon way.

@kimlaberinto
Copy link
Contributor Author

kimlaberinto commented Jan 25, 2021

It doesn't matter much to me of whether its at the top or not. For me personally, I'll most likely still use a custom post-metadata.html for my own website because I want to continue showing the tags up at the top, but I wanted to proposed this in case anyone else wanted it for the overall theme.

It does make sense for the theme to be minimal.

Disclaimer: I don't design websites, so these are just my personal non-professional opinions.

I like having the tags up at the top because I don't find them too obtrusive. It still feels simple to me. I think the tags at the top allow website visitors to quickly get a glance of what the post is about. It also gives them a chance to click the link and view other posts with the same tag and continue browsing for similar content.

I also decided to keep the tags at the bottom so once a visitor to done reading the website, they can click on the tags to view other similar posts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants