support darwin cpu execution. #77
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR depends on the publishing of the binaries and ability to download them upon install. |
faridyagubbayli
approved these changes
Dec 26, 2022
|
compilation is currently working but without openmp which makes it unbearably slow. Need to work on static compilation with openmp before merging this. |
# Conflicts: # examples/bmode_reconstruction_example.py # kwave/executor.py
|
Currently, this branch of the k-wave binaries compiles and runs but returns Nans. This will need to be corrected before support for MacOS M1 can be merged in. |
waltsims
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds darwin cpu execution of k-wave simulations and depends on darwin compilation of the binaries which will be published to github shortly.
closes #69