Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Benchmarks #326

Draft
wants to merge 52 commits into
base: master
Choose a base branch
from
Draft

[WIP] Benchmarks #326

wants to merge 52 commits into from

Conversation

djps
Copy link
Collaborator

@djps djps commented Feb 25, 2024

As a work in progress, can't be merged, but

  • What figures and analysis should be performed?

As it is not part of the k-wave example set things are less well-defined.

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 67.78%. Comparing base (0911060) to head (c819b31).

Files Patch % Lines
kwave/utils/filters.py 66.66% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
+ Coverage   67.76%   67.78%   +0.02%     
==========================================
  Files          48       48              
  Lines        7066     7071       +5     
  Branches     1605     1605              
==========================================
+ Hits         4788     4793       +5     
- Misses       1697     1698       +1     
+ Partials      581      580       -1     
Flag Coverage Δ
3.10 67.94% <66.66%> (+0.02%) ⬆️
3.11 67.94% <66.66%> (+0.02%) ⬆️
3.12 67.94% <66.66%> (+0.02%) ⬆️
3.9 67.75% <66.66%> (+0.02%) ⬆️
ubuntu-latest 67.72% <66.66%> (+0.02%) ⬆️
windows-latest 67.72% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waltsims
Copy link
Owner

Since it is a benchmark a description of the benchmark with a link to the paper, one figure and a table with the performance results would be a good place to start. What do you think?

@waltsims waltsims marked this pull request as draft February 27, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants