Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update logic to prevent duplicate workflows #235

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

waltsims
Copy link
Owner

No description provided.

@waltsims waltsims marked this pull request as draft December 20, 2023 19:18
@faridyagubbayli
Copy link
Collaborator

What is the aim of this PR?

@waltsims
Copy link
Owner Author

What is the aim of this PR?

We currently have duplicate CI workflows running in pull requests. The CI is triggered for pushed code and pull requests. This PR was aimed at ensuring the CI was triggered only once. It seems it's not so simple at first glance.

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.97%. Comparing base (6c5ef8a) to head (f9a33ef).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   67.97%   67.97%           
=======================================
  Files          48       48           
  Lines        7050     7050           
  Branches     1604     1604           
=======================================
  Hits         4792     4792           
- Misses       1684     1685    +1     
+ Partials      574      573    -1     
Flag Coverage Δ
3.10 68.16% <ø> (ø)
3.11 68.16% <ø> (ø)
3.12 68.16% <ø> (ø)
3.9 67.96% <ø> (ø)
ubuntu-latest 67.97% <ø> (ø)
windows-latest 67.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waltsims
Copy link
Owner Author

waltsims commented Feb 4, 2024

This now only runs the ci on Pars. This logic makes sense since the master branch is protected.

@waltsims waltsims marked this pull request as ready for review February 4, 2024 04:43
@waltsims waltsims added this to the v0.3.3 milestone Feb 27, 2024
@waltsims waltsims modified the milestones: v0.3.3, v0.3.4 Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants