New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: store sites that are rendered on the frontend #7060
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About tests: maybe you can add one more job into https://github.com/wallabag/wallabag/blob/master/.github/workflows/continuous-integration.yml
where you choose one version of PHP, install/enable/run single-file-proxy
About the doc, it'll be at https://github.com/wallabag/doc but maybe you can wait for the PR to be ok before starting writing the doc.
app/config/wallabag.yml
Outdated
# - https://www.blast-info.fr | ||
# - https://www.arretssurimage.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment about app/config/parameters.yml.dist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better as an application-level config, something like the Site credential management?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This point remains unfixed. I'll have a look at this app-level integration now.
closes #6737
This adds single-file-proxy integration.
The proxy will render sites in a headless Chromium, returning the resulting page content. This makes Wallabag able to store sites that are rendered in JS.
Two operating modes (in
parameters.yml
):The proxy itself will only process sites that are defined in his own whitelist. It will HTTP Redirect others.
It seems safe to proxy all (only drawback is the external dependency for overall operation of Wallabag).
Questions to team: