Fix installer when database not exists #6739
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j0k3r
reviewed
Jul 19, 2023
app/config/parameters.clean
Outdated
nicosomb
force-pushed
the
fix-install-db-not-exists
branch
from
1b33a47
to
a848281
Compare
|
All is green but the CI is broken 😉 |
Kdecherf
requested changes
Jul 19, 2023
| @@ -151,3 +151,65 @@ jobs: | |||
|
|
|||
| - name: "Run PHPUnit" | |||
| run: "php bin/simple-phpunit -v" | |||
|
|
|||
| phpunit_no_database: | |||
There was a problem hiding this comment.
I'm not a big fan of running these new tests on all PR as it unnecessarily increases load on the CI. @nicosomb could we disable them by default (or drop the commit before merging)?
There was a problem hiding this comment.
Maybe we can just keep one? For MySQL or PG
nicosomb
force-pushed
the
fix-install-db-not-exists
branch
from
1d2dc8a
to
a2a3bb3
Compare
nicosomb
force-pushed
the
fix-install-db-not-exists
branch
from
a2a3bb3
to
e185e03
Compare
|
@j0k3r can you help me about the new build to create please? |
|
@nicosomb the build seems ok now, but tests are failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd prefer have a regex to check the whole exception message. If someone wants to have a look on it.
My PR is a pointer to the bug, we can improve it.
I want to kill an other bug quickly #6659