Throw errorin interpolate_pw() if inputs have different CRS and CRS not supplied #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think my changes would have have had any effect on package compilation. I'm not familiar enough with R development on Windows to tell if the windows-latest check failure is an actual issue, or something going on with the runner. @walkerke could you let me know if I need to modify my code at all? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check to see if
from,to, andweightshave the same CRS if CRS is not supplied as a function argument tointerpolate_pw(). This saves time ifweightsis large and a long time is spent generating centroids beforesf::st_join()will inevitably fail when trying to createdenomiatorsdue to the mismatched CRS.