use named subsetting instead of sorting

waldronlab · Aug 8, 2023 · f507624 · f507624
1 parent f7d8a9c
commit f507624
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/R/MultiAssayExperiment-class.R b/R/MultiAssayExperiment-class.R
@@ -380,9 +380,9 @@ MultiAssayExperiment <-
     colNams <- Filter(function(x) !isEmpty(x), colnames(object))
     msg <- NULL
     if (length(colNams)) {
-        logicResult <- mapply(function(x, y) {
-            identical(sort(x), sort(y))
-        }, x = colNams, y = assayCols)
+        logicResult <- mapply(function(x, y, nm) {
+            identical(x[nm], y[nm])
+        }, x = colNams, y = assayCols, nm = names(colNams))
         if (!all(logicResult))
             msg <- "not all ExperimentList samples are found in the sampleMap"
     }