Supports remote backup push from PostgreSQL 15 or later (#1385) #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In the streamFromPostgres method, CopyData case adds data receiving processing from pgsql version 15 or later. * In the streamFromPostgres method, add NoticeResponse case. * Troubleshoot EOF problems caused by the last zeroBlock message sent from pgsql15 or later. * Add test for Supports remote backup push from PostgreSQL 15 or later Signed-off-by: tangtx <tianxitang@harmonycloud.cn>
|
Can the code owner help me review the code? THX！ |
|
What needs to be done to get this reviewed and merged? We would like to use the remote backup feature for our PG15+ clusters, and would prefer not to maintain/run a fork. |
|
@debebantur Can you please take a look on the code? Architecturally the feature seem important. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database name
PostgreSQL
Pull request description
Supports remote backup push from PostgreSQL 15 or later (#1385)
Describe what this PR fix
Please provide steps to reproduce (if it's a bug)
wal-g backup-pushERROR: 2023/11/16 10:37:36.274535 unexpected response: &{%!t(string=ERROR) %!t(string=ERROR) %!t(string=42601) %!t(string=syntax error) %!t(string=) %!t(string=) %!t(int32=0) %!t(int32=0) %!t(string=) %!t(string=) %!t(string=) %!t(string=) %!t(string=) %!t(string=) %!t(string=) %!t(string=repl_scanner.l) %!t(int32=247) %!t(string=replication_yyerror) map[]}Please add config and wal-g stdout/stderr logs for debug purpose
test case！
AWS_ACCESS_KEY_ID=minio;
AWS_ENDPOINT=http://127.0.0.1:32009;
AWS_S3_FORCE_PATH_STYLE=true;
AWS_SECRET_ACCESS_KEY=123456;
PGHOST=127.0.0.1;
PGPASSWORD=123456;
PGPORT=5432;
PGUSER=postgres;
WALE_S3_PREFIX=s3://test-pg/pg15-1116