Feature/envelope pgp #1547
Merged
Feature/envelope pgp #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 5, 2023 12:27
# Conflicts: # internal/configure.go
Alviner
commented
Sep 5, 2023
|
|
||
| import "io" | ||
|
|
||
| //go:generate mockery --name Enveloper --with-expecter=true |
There was a problem hiding this comment.
There is no standart mock gen in project.
Should we make an issue in backlog for that?
There was a problem hiding this comment.
Yes, the current zoo of mock generators is confusing and needs to be fixed eventually. Would appreciate an issue addressing this.
Alviner
commented
Sep 6, 2023
usernamedt
requested changes
Sep 6, 2023
detect crypto type at first then configure particular
usernamedt
requested changes
Sep 7, 2023
usernamedt
requested changes
Sep 7, 2023
usernamedt
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database name
Enveloped gpg via yckms was added to WAL mondo/pg/sqlserver
Pull request description
Use Envelope encryption on gpg keys to stop storing the original gpg (dek key) in the system and make possible a painless gpg key rotation.
TBD:
clean configure to prevent setting both gpg and encrypted gpg
make ttl cache on yckms enveloper
make stale cache on yckms envelope
docs
try to setup yckms mock) it useaws local kms use http(