-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass Context around Folder upload functions, add PG WAL push timeout #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ne2pit
requested review from
perekalov,
VGoshev,
KhurtinDN,
mialinx,
ostinru,
teem0n and
a team
as code owners
September 4, 2023 23:12
# Conflicts: # cmd/common/st/put_object.go # internal/storagetools/put_object_handler.go
serprex
reviewed
Sep 5, 2023
usernamedt
requested changes
Sep 6, 2023
I also suggest to add the new setting to the WAL-G daemon docs. |
usernamedt
requested changes
Sep 8, 2023
todo: Add Swift and SSH docker tests to @if [ "$(TEST)" = "pg_tests" ]; then\
docker-compose build ssh &&\
docker-compose up --exit-code-from pg_storage_swift_test pg_storage_swift_test &&\
docker-compose up --exit-code-from pg_storage_ssh_test pg_storage_ssh_test ;\
fi Similar changes are made in #1551 . Doing so in parallel will lead to merge conflicts. It is possible to add it to one of two PRs that will be merged second. |
usernamedt
approved these changes
Sep 11, 2023
teem0n
approved these changes
Sep 11, 2023
KhurtinDN
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database name
Timeout is added to Postgres WAL push. Changes in Upload is common for all DBs.
Pull request description
Side changes