Add dir database composer for Greenplum #1493
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikifkon
force-pushed
the
gp_dir_db_composer
branch
from
f046fe4
to
39d5a1f
Compare
nikifkon
force-pushed
the
gp_dir_db_composer
branch
from
39d5a1f
to
39c2a1d
Compare
|
nothing chage's in Add dir db composer and add docs just rebasing to master |
usernamedt
requested changes
Jul 17, 2023
| } | ||
|
|
||
| func (d *DirDatabaseTarBallComposer) addFile(cfi *internal.ComposeFileInfo) error { | ||
| // WAL-G uploads AO/AOCS relfiles to a different location |
There was a problem hiding this comment.
This logic is getting duplicated. Maybe extract it to some common place? And maybe rename greenplum_tar_ball_composer to the regular_tar_ball_composer since it is no longer the only one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database name
Greenplum
Pull request description
Add
--database-composerto thebackup-pushcommand, which affects the way non-ao files are packaged and increases the likelihood of skipping tar during partial backups