New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another backup naming scheme #1476
Open
AlexUran
wants to merge
26
commits into
wal-g:master
Choose a base branch
from
AlexUran:fix-delta-backups-push-fails-when-no-changes
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Another backup naming scheme #1476
AlexUran
wants to merge
26
commits into
wal-g:master
from
AlexUran:fix-delta-backups-push-fails-when-no-changes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexUran
changed the title
Use info logger instead of error for delta backup error
Use info logger instead of fatal error for delta backup error
May 18, 2023
This reverts commit ab18ab4.
AlexUran
changed the title
Use info logger instead of fatal error for delta backup error
Another backup naming scheme
Jun 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database name
Postgres
Pull request description
ERROR with LSN, when trying to make a backup without changes. Original issue: #1089
Describe what this PR fix
Use naming scheme based on timestamp, instead of lsn-based name. It prevents identical backups names error.