fix os.walk not guarantee alphabet order and tar exit with code 1 after can't overwrite existsting folder and pipe will freeze when backup-fetch run #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er can't overwrite existsting folder and pipe will freeze when backup-fetch run Signed-off-by: Slach <bloodjazman@gmail.com>
Signed-off-by: Slach <bloodjazman@gmail.com>
Signed-off-by: Slach <bloodjazman@gmail.com>
Signed-off-by: Slach <bloodjazman@gmail.com>
Signed-off-by: Slach <bloodjazman@gmail.com>
Signed-off-by: Slach <bloodjazman@gmail.com>
|
Does this patch fix it? |
|
yep, currently we using swift client without ovhfs |
|
Could you do me a favor and clean up the commit history however you see fit? |
Signed-off-by: Slach <bloodjazman@gmail.com>
|
@fdr sorry for late little bit necro reply ;) but not github allow squash commit, could you squash and merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i run backup-fectch with --file-prefix using mounted swift partition over https://github.com/ovh/svfs
and wal-e was freezing when something wrong inside lzop and tar pipe