Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop React #715

Open
4 tasks
zerolab opened this issue Sep 22, 2023 · 2 comments
Open
4 tasks

Drop React #715

zerolab opened this issue Sep 22, 2023 · 2 comments
Labels
type: DX Developer eXperience type:maintenance

Comments

@zerolab
Copy link
Collaborator

zerolab commented Sep 22, 2023

While the initial plans were grandiose, they never came to fruition and the focus, requirements and direction have changed. This means the React side of things make maintenance harder than it needs to be.

We should switch to regular HTML with a sprinkle of AJAX (the edit a particular translation bit)

This will allow us to keep up with any Wagtail UI changes and focus on more important functionality and bug fixes

Tasks

@lb-
Copy link
Member

lb- commented Oct 7, 2023

Just dropped into this repo and saw this, if you need something similar to HTMX's swap (for Ajax style behaviour).

Maybe check out the Swap controller - https://github.com/wagtail/wagtail/blob/main/client/src/controllers/SwapController.ts

Some others may come in handy also.

May be a bit easier that rolling too much custom JS, just patch in to any DOM events as needed. Might be a good use case to se how the Stimulus controllers can be leveraged for plugins.

I also understand if the desire is not to be tied to undocumented (yet) Wagtail internals.

@zerolab
Copy link
Collaborator Author

zerolab commented Oct 7, 2023

@lb- thanks for the pointers. I am on a fence about adopting Stimulus in that we still support 4.1 as the LTS and my goal is to reduce additional FE tooling as much as possible because it is a maintenance burden. My goal is to rely on as much core stuff as we can, with a sprinkle of plain JavaScript where needed.

Patching in to any existing DOM events does sound appealing. Will have a think how we can make this work. Gotta spec this out carefully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: DX Developer eXperience type:maintenance
Projects
None yet
Development

No branches or pull requests

2 participants