Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Chooser not used used in translation mode #717

Open
enzedonline opened this issue Sep 29, 2023 · 1 comment
Open

Custom Chooser not used used in translation mode #717

enzedonline opened this issue Sep 29, 2023 · 1 comment

Comments

@enzedonline
Copy link
Contributor

I'm using image and page choosers with the edit button removed from the chosen item ({"show_edit_link":False}), for both FieldPanels and ChooserBlocks. It's particularly causing a problem in translation mode where translation editors are choosing the edit button instead of change. They realise the mistake on the page chooser, but the image chooser often ends up with the editor uploading the locale specific image to replace the original, it's not so obvious to the editor that they are overriding the original image.

That works fine on the source page, but the translation page ignores the widget settings.

image

To me, the edit link doesn't belong on the translation page at all, but at the least, the translation page should be using the same widget and widget attributes.

The edit link can be hidden with some css as a last resort, but would be good to get consistency between source page and translation page.

@zerolab
Copy link
Collaborator

zerolab commented Sep 29, 2023

Thank you for raising this, @enzedonline. I agree we should at the very least respect the attributes.

One more case for dropping the React side of things (#715). Adding to the list.

If you do happen to have the time to look into the existing code, it would be most welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants