Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add badges for tools #323

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add badges for tools #323

wants to merge 5 commits into from

Conversation

egekorkan
Copy link
Contributor

@egekorkan egekorkan commented May 23, 2022

I have started adding the badges to the tools. It is still a WIP due to following points:

  • Not sure how to put the badges under the description of each tool without making the place that each tool takes somewhat bigger vertically
  • My frontend development knowledge barrier: It would be better if these badges are some sort of a CSS class so that each tool only inherits the badge instead of copy pasting. I have copy pasted for playground now

fixes #319

@netlify
Copy link

netlify bot commented May 23, 2022

Deploy Preview for wot-marketing ready!

Name Link
🔨 Latest commit 5679ef6
🔍 Latest deploy log https://app.netlify.com/sites/wot-marketing/deploys/62a75ba28cbbb90009e678cf
😎 Deploy Preview https://deploy-preview-323--wot-marketing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danielpeintner
Copy link
Contributor

Personally I don't like the intro for the badges (looks a bit chaotic to me).

grafik

It lists all badges and I have still to hover over to see the text. I would rather put the text there (left-aligned) without hovering OR remove the intro for the badges at all. People will know what to do.

The only down-side of leaving away the intro is mobile where it will not work. But it will not work in the current fashion either..

@danielpeintner
Copy link
Contributor

Note: One more visual feedback from my side. I think the initial icons/text for "TD Tooling", "WoT Development Tools" etc seems rather big.. but maybe it is just my feeling..

grafik

@egekorkan
Copy link
Contributor Author

I can regroup like that. It is true that hovering is simply not going to work in mobile :/ I wanted to not have so much text taking place

Regarding the logos, I can make them smaller :)

@egekorkan
Copy link
Contributor Author

@danielpeintner I have made the icons in the beginning smaller and added an alternative badge intro

@egekorkan
Copy link
Contributor Author

Call of 24.05:

  • Alternative 1 is not picked by anyone, alternative 2 can stay
  • We should not add any more badges, 11 is already quite a lot
  • In the section where the tools are listed, it might be better to put a table with tool name, description, badges -> This is what the group has picked
  • Another proposal is that when a category is selected, the other tools are hidden

@danielpeintner
Copy link
Contributor

I missed the last call and based on the current preview I am not quite sure what is meant to stay and what not 🙃

@egekorkan
Copy link
Contributor Author

I missed the last call and based on the current preview I am not quite sure what is meant to stay and what not 🙃

I have started the work in this but it got messy and I did not have time. The current preview should not be taken seriously ^_^

@egekorkan
Copy link
Contributor Author

We can also use shields.io for the badges as well. Might solve the class issue mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Badges for tools
2 participants