Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube Videos in Website #155

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

handealptekin
Copy link
Contributor

  • Each tutorial's youtube video is added as embedded player to their page
  • A link to the github tutorial mp4 is added as a link for users who cannot reach Youtube

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for whatiswot ready!

Name Link
🔨 Latest commit b35567c
🔍 Latest deploy log https://app.netlify.com/sites/whatiswot/deploys/662ac10caae7b0000871c5da
😎 Deploy Preview https://deploy-preview-155--whatiswot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@egekorkan egekorkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we need to wait for #152 since I think that the video links will change when the new ones are uploaded.

@@ -4,6 +4,13 @@ sidebar_label: Tutorial Introduction

# What is WoT?

<iframe width="100%" height="400" src="https://www.youtube.com/embed/xyin2oLLpYY?si=G6TDeDcNtQC3HNeC" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" referrerpolicy="strict-origin-when-cross-origin" allowfullscreen></iframe>

<a href = "https://github.com/w3c/wot-cg/blob/main/Tutorials/whatiswot/1-WoT/1-WoT.mp4">Click here if YouTube does not work to download:</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href = "https://github.com/w3c/wot-cg/blob/main/Tutorials/whatiswot/1-WoT/1-WoT.mp4">Click here if YouTube does not work to download:</a>
<a href = "https://github.com/w3c/wot-cg/blob/main/Tutorials/whatiswot/1-WoT/1-WoT.mp4">Click here if YouTube does not work to go to our GitHub.</a>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be applied to all videos

@egekorkan egekorkan linked an issue Apr 26, 2024 that may be closed by this pull request
@egekorkan
Copy link
Collaborator

We should add to first wot page to fix the first item of #152 :

Video 2, Payloads and Headers, around 0:30: We say click on the cards but there is no card. We do not have the videos yet but we can at least point to the webpage and the webpage can have "Video will be available soon" placeholder.

@egekorkan egekorkan marked this pull request as draft April 26, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embedding YouTube into Webpage
2 participants