Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cross-spec section autolinks instead of absolute URLs #169

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

tidoust
Copy link
Member

@tidoust tidoust commented Nov 24, 2023

This is purely editorial. The spec had a couple of places where it referenced a section of other specs (RFC9110 and Fetch) using absolute URLs. This update rather uses the recommended cross-spec section autolink: https://speced.github.io/bikeshed/#autolink-biblio

This will allow Bikeshed to detect and alert you should the fragment identifiers change in the targeted specifications, as well as to follow the specification if its URL changes (the cross-references database typically now uses the httpwg.org/specs/ URL for RFC9110 as it is slightly more readable).


Preview | Diff

@tidoust
Copy link
Member Author

tidoust commented Nov 24, 2023

Note I was a bit too prompt to create the PR. The new data has not yet reached the online Bikeshed service that the build code uses to generate the spec. That should happen soon...

@domfarolino
Copy link
Member

I think this should be good to go now, but you probably need to rebase it on top of the new main head for the build to succeed, since when I re-ran it, there was a build failure that I have just now fixed. Could you do that?

This is purely editorial. The spec had a couple of places where it referenced a
section of other specs (RFC9110 and Fetch) using absolute URLs. This update
rather uses the recommended cross-spec section autolink:
https://speced.github.io/bikeshed/#autolink-biblio

This will allow Bikeshed to detect and alert you should the fragment
identifiers change in the targeted specifications, as well as to follow the
specification if its URL changes (the cross-references database typically now
uses the `httpwg.org/specs/` URL for RFC9110 as it is slightly more readable).
@tidoust
Copy link
Member Author

tidoust commented Dec 4, 2023

I think this should be good to go now, but you probably need to rebase it on top of the new main head for the build to succeed, since when I re-ran it, there was a build failure that I have just now fixed. Could you do that?

Yes, done! I rebased and force-pushed the update.

Copy link
Member

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@domfarolino domfarolino merged commit c7db4d9 into w3c:main Dec 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants