Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix s4.8.1.3.06/07 test fixtures #57

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix s4.8.1.3.06/07 test fixtures #57

wants to merge 1 commit into from

Conversation

naglis
Copy link

@naglis naglis commented Oct 16, 2020

From https://www.w3.org/TR/pub-manifest/#manifest-embed:

When a digital publication format allows manifests to be embedded within an HTML document, the manifest MUST be included in a script element whose type attribute is set to application/ld+json.

@naglis
Fix s4.8.1.3.06/07 test fixtures
72d3d67 
From https://www.w3.org/TR/pub-manifest/#manifest-embed:

> When a digital publication format allows manifests to be embedded
> within an HTML document, the manifest *MUST* be included in a `script`
> element whose `type` attribute is set to `application/ld+json`.
@naglis naglis changed the title Fix s4.8.1.3.06 test fixture Fix s4.8.1.3.06/07 test fixtures Oct 16, 2020
@naglis
Copy link
Author

naglis commented Oct 16, 2020

I see that type is missing from more other HTML documents ([1], [2], ...) embedding a manifest. Please let me know if I am misunderstanding the specification or the other fixtures should be updated as well.

Base automatically changed from master to main February 4, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@naglis