New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partially addresses Issue 275 #308
Conversation
@@ -425,7 +427,12 @@ | |||
<p> | |||
The header <dfn><a href= | |||
"https://tools.ietf.org/html/rfc7231#section-5.3.5">Accept-Language</a></dfn> | |||
is defined in HTTP 1/.1 [[!rfc7231]]. | |||
and is defined in HTTP/1.1 [[!rfc7231]]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: drop "and"
interoperable behavior for 1-UA and 2-UA presentations. For | ||
example, navigation is not allowed in a <a>receiving browsing | ||
context</a>. | ||
</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the note, instead of "The receiving browsing context", I would rather use "This algorithm" (or "These steps").
Also, readers won't have the full context of WG discussions, and "private browsing session" comes a bit out of the blue here. I would simply strike that part and simply assert the intent.
Where do we say that navigation is not allowed in a receiving browsing context? The auxiliary navigation browsing context flag merely prevents the creation of additional browsing contexts, for instance. What the spec rather says is that the receiving user agent must terminate the presentation in case of navigation.
All in all, I would simplify the note to:
<p class="note">
This algorithm is intended to create a well defined environment to allow interoperable behavior for 1-UA and 2-UA presentations.
</p>
Thanks @mfoltzgoogle. See additional comment on the note. The pull request looks good to me otherwise. Not directly related to this pull request, but re-reading the algorithm, I think it does not really achieve what we'd like it to do. My understanding is that we'd like the user agent to create or use dedicated storages in the 1UA case. However:
Perhaps we can assume that the notion of storage is straightforward to grasp and tell the user agent to create new empty storages for the receiving browsing context in all cases, as in:
I don't find that entirely satisfactory though. Any better idea? |
@tidoust's proposed text looks pretty good to me (copy-paste-able proposals in HTML are nice :-)). @mfoltzgoogle, given no concerns in 12 days after the @tidoust's proposal was aired, I suggest you update the PR with #308 (comment) and merge (after rebase & resolve merge conflicts). |
To clarify, @tidoust noted Service Workers-provided dedicated storage (the To not block CR on the Service Workers considerations, we can note that in the SoTD as a WIP issue, unless we address this soon. |
I'm okay with the text suggested by @tidoust in #308 (comment) and #308 (comment). I think it's the best that can be done given the specs we are referring to here, and vendors will have to interpret the spirit of the spec going forward as new storage APIs get deployed. |
Adopted proposals from @tidoust with some minor edits to define local storage and session storage areas. Merging. |
This PR implements parts of the resolution for Issue #275: User Data Controls in Web Browsers guidelines. It also updates the list of site data to reflect implementation status in the receiving user agent.
The parts remaining to be done include: