Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split interface Presentation IDL into partials #267

Merged
merged 2 commits into from
Feb 15, 2016

Conversation

anssiko
Copy link
Member

@anssiko anssiko commented Feb 15, 2016

@mfoltzgoogle @louaybassbouss Please review.

@louaybassbouss
Copy link
Contributor

@anssiko LGTM. In addition to your changes, I'd like to add for all IDLs the class idl-controlling-ua or idl-receiving-ua to make extraction (programatically) of IDLs for only controlling UA or receiving UA easier. If an IDL is required for both conformance classes (e.g. PresentationConnection), we can assign the two classes to the IDL at same time. What do you think?

anssiko added a commit that referenced this pull request Feb 15, 2016
Split interface Presentation IDL into partials
@anssiko anssiko merged commit f6e622f into gh-pages Feb 15, 2016
@anssiko
Copy link
Member Author

anssiko commented Feb 15, 2016

@louaybassbouss Thanks for the review.

We should add such metadata if it makes test generation easier. I opened a new issue and updated the meta issue accordingly.

@anssiko anssiko deleted the issue-230-presentation-interface branch February 15, 2016 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Presentation API IDL Tests for Presentation Interface
2 participants