Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multimeasure rests to spec, with example #285

Merged
merged 4 commits into from Aug 20, 2022
Merged

Conversation

adrianholovaty
Copy link
Contributor

This pull request adds multimeasure rests to the spec, along with an example document. This is based on the agreed-upon approach from #284.

The updated docs (as of this pull request) are visible here: https://cdn.githubraw.com/w3c/mnx/multimeasure-rests/docs/

Here's the example document: https://cdn.githubraw.com/w3c/mnx/multimeasure-rests/docs/mnx-reference/examples/multimeasure-rests/

@cecilios and @clnoel — mind reviewing to make sure everything matches our discussion?

@clnoel
Copy link

clnoel commented Aug 16, 2022

This looks like what we agreed, although I might have added the page and system tags into the part scores in order to clarify the sibling relationship.

However, I am now throwing a wrench in the works. We either need to decide to support the old-style rest format, or decide to put it off until later. We shouldn't forget about it. As recently as last year people were trying to add this to MuseScore.
image
--Christina

@adrianholovaty
Copy link
Contributor Author

@clnoel Thanks! I've just created issue #286 to collect discussion/ideas for the old-style format. I don't think the lack of that should block this particular pull request, but I do want to make sure we don't lose track of it.

@adrianholovaty adrianholovaty merged commit 8e4c1fb into main Aug 20, 2022
@adrianholovaty adrianholovaty deleted the multimeasure-rests branch August 20, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants