Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: add better example of scope #958

Merged
merged 3 commits into from Mar 5, 2021
Merged

Editorial: add better example of scope #958

merged 3 commits into from Mar 5, 2021

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Mar 4, 2021 •
edited by pr-preview bot

Closes #380

This change (choose at least one, delete ones that don't apply):

  • Makes editorial changes (changes informative sections, or changes normative sections without changing behavior)

Commit message:
Clarifies the how scope works, how it relates to the manifest being "applied", and limitations.

Preview | Diff

benfrancis
benfrancis reviewed Mar 4, 2021
View reviewed changes
index.html Outdated Show resolved Hide resolved
@marcoscaceres marcoscaceres merged commit 674c297 into gh-pages Mar 5, 2021
@marcoscaceres marcoscaceres deleted the scope-example branch March 5, 2021 03:47
@marcoscaceres
Copy link
Member Author

Thanks @benfrancis and @christianliebel for checking it over!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benfrancis benfrancis benfrancis left review comments

@christianliebel christianliebel christianliebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide better examples of scope
3 participants
@marcoscaceres @benfrancis @christianliebel