Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe manifest update behavior #1011

Merged
merged 15 commits into from Feb 17, 2022
Merged

Conversation

philloooo
Copy link
Collaborator

@philloooo philloooo commented Sep 29, 2021

closes #446
This change is dependent on #988

This change (choose at least one, delete ones that don't apply):

  • Makes editorial changes (changes informative sections, or changes normative sections without changing behavior)

Commit message:

(Fill in. If making normative changes, describe exactly what the behavioral
difference will be.)

Person merging, please make sure that commits are squashed with one of the following as a commit message prefix:

  • chore:
  • editorial:
  • BREAKING CHANGE:
  • And use none if it's a normative change

Preview | Diff


Preview | Diff

@philloooo philloooo mentioned this pull request Sep 29, 2021
5 tasks
index.html Show resolved Hide resolved
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philloooo, happy to work on this together... I can take the HTML spec updates if you'd like.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
@marcoscaceres
Copy link
Member

marcoscaceres commented Feb 3, 2022

From our call today:

For the purpose of updating, the following member are security-sensitive members, as they are presented during installation and on launch surfaces:

  • [=manifest/name=],
  • [=manifest/short_name=],
  • [=manifest/icons=]

User agents SHOULD NOT automatically apply changes to [=security-sensitive members=] without [=express permission=] from the user.

Instead, user agents SHOULD present changes to [=security-sensitive members=] with appropriate management options, so the user can make an informed decision about updating the web application.

The user agent MAY automatically apply the changes if the update does not contain changes to [=security-sensitive members=].

Aside: A user agent won't not apply a partial update.

For example, the user agent could present options to the user:

  • Accept the update
  • uninstall the web app, or
  • report the website as abusive.

@aarongustafson
Copy link
Collaborator

Sounds reasonable. Is there any option for a UA to make a determination on the relative substance of the change? For example, if the name went from Company to Company™, that's not terribly significant. Same could be said for changing the colors of an icon while maintaining the same design. I'm not suggesting how the UA might determine the substance of a change and where they should peg the threshold of needing to inform the user, but it could cut down on unnecessary notices.

@marcoscaceres
Copy link
Member

Is there any option for a UA to make a determination on the relative substance of the change?

Sure, it's all just "recommendations" after all. However, implementers would do that at their own risk because an attacker would try to abuse such heuristics if/where possible.

We might need to add that to the Security Considerations.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
philloooo and others added 4 commits February 16, 2022 16:17
Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
<aside class="note" title=
"A user agent will not apply a partial update">
<p>
When the update contains changes both to [=security-sensitive
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcoscaceres I've added some context to the partial update note, let me know what you think.

index.html Outdated Show resolved Hide resolved
index.html Outdated
Comment on lines 1479 to 1480
<li>Report the website as abusive/spam.
</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li>Report the website as abusive/spam.
</li>
<li>Report the website as malicious.
</li>

philloooo and others added 2 commits February 16, 2022 16:40
Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
@marcoscaceres marcoscaceres merged commit 54acb9e into w3c:gh-pages Feb 17, 2022
@dmurph
Copy link
Collaborator

dmurph commented Mar 1, 2022

Adding myself in comments for searching purposes

mfreed7 pushed a commit to mfreed7/html that referenced this pull request Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify how updates work
5 participants