Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
0033f23
commit cbd8343
Showing
1 changed file
with
41 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbd8343
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this supposed to be used? What if the site works just as well in more than one lang?
cbd8343
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hardcoding languages doesn't seem to help i18n, but might actually do the opposite
cbd8343
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's for the "primary" language. You can still have multiple languages.
Maybe, but it's the best we can do with JSON (define the primary lang). It's doesn't give us the flexibility of XML (we solved all this stuff easily with XML, but here it's basically impossible without making a huge mess). We went JSON, so let's just live with it.
cbd8343
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it is probably fine. I actually think that adding all different languages in one manifest file is the wrong approach (bigger download, slower parsing etc) and the .desktop format on Linux showed that.
Generating the manifest.json on the server and defining what language it is in should be fine... maybe some words on i18n and generating the manifest on the server?
cbd8343
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Precisely what #323 is about :)