Feature/attributes #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jean-gui
requested changes
Aug 24, 2023
| * @return object|null object of same class as $attributeClass or null if no attribute is found | ||
| * @throws ReflectionException | ||
| */ | ||
| public function getAnnotation(string $class, string $attributeClass): ?object |
There was a problem hiding this comment.
Can you rename that to getAttribute?
| * @return object|null object of same class as $attributeClass or null if no attribute is found | ||
| * @throws ReflectionException if the field does not exist | ||
| */ | ||
| public function getPropertyAnnotation(ClassMetadata $classMetadata, string $field, string $attributeClass): ?object |
There was a problem hiding this comment.
Can you rename to getPropertyAttribute?
| class AttributeGetter | ||
| { | ||
| /** | ||
| * Get a class-level annotation |
There was a problem hiding this comment.
Suggested change
| * Get a class-level annotation | |
| * Get a class-level attribute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will require a new major version.
I've implemented this bundle to support attributes instead of annotations. Since this bundle seems to be feature-complete anyway, I do not think it would make much sense to have additional complexity to support both (annotations and attributes) at the same time. <PHP8 users or users who want annotations can just use an older version.
I've based this PR on my other PR #18 which should be merged first.