Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend using extended transfer functions to handle negative values #434

Merged
merged 2 commits into from Mar 4, 2024

Conversation

svgeesus
Copy link
Contributor

@svgeesus svgeesus commented Mar 1, 2024

Would fix #420

Copy link
Contributor

@simontWork simontWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. (I've just realised I made a pull request against my fork rather than W3C's with similar text)

Copy link
Collaborator

@ProgramMax ProgramMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

index.html Outdated
<p>If <code>Video Full Range Flag</code> is <code>0</code>
(a <a>narrow-range image</a>), recommended practice
is to define transfer functions
such as EOTF or inverse OETF
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EOTF acronym doesn't seem to be defined anywhere else in the document. It would be nice to avoid introducing new terminology just to explain how to handle the Full Range flag, but at very least the terminology should be defined

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better?

@svgeesus
Copy link
Contributor Author

svgeesus commented Mar 1, 2024

Re-requesting reviews due to addition of EOTF and OETF definitions

@svgeesus svgeesus merged commit b6fc21e into main Mar 4, 2024
1 check passed
@svgeesus svgeesus deleted the 420-fullrange-negative branch March 4, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reccomend how to deal with negative values
4 participants