Solving #28 and #33 #37
Conversation
0x1daniel
changed the title
|
@davidlazar Is the development still alive? |
|
Can you follow the Go convention for commit messages? https://golang.org/doc/contribute.html#commit_messages Also, "clean the code" should be a separate pull request. |
|
@davidlazar I think the commit messages are already in the format you wished in an older closed pull request. And this commit message format is actually as described in the doc, without the huge message that would be only confusing at this point. And I will keep the |
|
@davidlazar ping |
|
I'd like for the commit messages to be consistent. The Go contribution guidelines say:
See here: https://golang.org/doc/contribute.html#commit_messages Thanks. |
|
@davidlazar Fixed commit messages |
|
@davidlazar ping |
|
@davidlazar Ready to merge |
| } | ||
| } else { | ||
| cmd := args[0] | ||
| var choices []string | ||
| switch cmd { | ||
| case "w": | ||
| case "w", "win": |
There was a problem hiding this comment.
It would be nice to not have to repeat the aliases here.
| Handler func(gc *GuiClient, args []string) error | ||
| } | ||
|
|
||
| var commands = map[string]Command{ | ||
| "help": { | ||
| Help: "/help prints this help message.", | ||
| Aliases: []string{}, |
@davidlazar Cleaned up the pull request.