fix: $rewardEarly implementation #1240
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes vuelidate#1237 1. Moved $lastInvalid assignment from the results.$invalid computed because computed props should be side-effect free. 2. Added $lastCommittedOn as a watch source because 3.4.x vue will cache computed more aggressively and $lastInvalidState would be out of sync in the "commit() when valid" scenario: - commit() sets $lastInvalidState to true - validators run and return invalid as false - result.$invalid is already false, so it will not recompute (cached) - the watcher will not be triggered because $result.$invalid dep did not change. - last $invalidState is not set to false, and thus $model change triggers validators to run. I don't know if it's out-of-scope of this PR to update vue, but 3.4.x brought many changes to computed optimization which vuelidate relies on heavily and it's the future. 3. flush "post" is required for async validators to work in this mode, otherwise last invalid state will be flipped to false since sync validators run first and turn invalid to false "before" pending is set to true and it will prevent them from running (Guessing). At least is required for 3.4.x and that's the version the majority should be using.
renatodeleao
changed the title
This was referenced Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
$lastInvalidsync assignment from theresults.$invalidcomputedbecause computed props should be side-effect free.
$lastCommittedOnas a watch source because3.4.xvue will cachecomputed more aggressively and
$lastInvalidStatewould be out of syncin the "commit() called when model valid" scenario:
$commit()sets$lastInvalidStatetotruefalseresult.$invalidcomputed is alreadyfalse(initial), so it will not recompute (cached)watcherwill not be triggered because$result.$invaliddep did not change.$invalidStateis not sync to false — to matchresult.$invalid, and thus$modelchange triggers validators to run immediately.last invalid state will be flipped to false since sync validators run first
and turn invalid to false "before" pending is set to true and it will prevent
them from running (Guessing). At least is required for 3.4.x and that's
the version the majority should be using.
I don't know if it's out-of-scope of this PR to update vue, but 3.4.x
brought many changes to computed optimization which vuelidate relies on
heavily and it's the future.
fixes #1237
Metadata
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
nextbranchfix #xxx[,#xxx], where "xxx" is the issue number)