Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Types (fix #1115) #1177

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

ig-onoffice-de
Copy link

@ig-onoffice-de ig-onoffice-de commented Apr 12, 2023

Summary

Make types of ValidationRule, helpers.regex and helpers.withParams more explicit.
fixes #1115

Metadata

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: Only added some types

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@dobromir-hristov
Copy link
Contributor

Hello there. Not a TS expert, but I will do my best to review later this week

@ig-onoffice-de
Copy link
Author

@dobromir-hristov Did I miss something or do you just need some time to review my change?

@ig-onoffice-de
Copy link
Author

@dobromir-hristov What happened to this pull request? 🥺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Typings
2 participants