Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: localize 404 page fix #1987 #2961

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yamashita-ki
Copy link

@yamashita-ki yamashita-ki commented Dec 11, 2021

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@yamashita-ki yamashita-ki changed the title fix(): localize 404 page fix #1987 fix: localize 404 page fix #1987 Dec 11, 2021
@yamashita-ki yamashita-ki changed the title fix: localize 404 page fix #1987 fix:localize 404 page fix #1987 Dec 11, 2021
@yamashita-ki yamashita-ki changed the title fix:localize 404 page fix #1987 fix: localize 404 page fix #1987 Dec 11, 2021
@yamashita-ki
Copy link
Author

Hey @meteorlxy
Would you mind checking this one?

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked the preview link, but found an obvious flash (from en to zn)

@yamashita-ki
Copy link
Author

@ulivz
I would like to ask you two things.

I just checked the preview link, but found an obvious flash (from en to zn)

So, 404 page supports i18n without my commit?

obvious flash

flash means session flash?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants