Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 7191 - data arg merge #7192

Merged
merged 3 commits into from Dec 6, 2017
Merged

Fix 7191 - data arg merge #7192

merged 3 commits into from Dec 6, 2017

Conversation

Akryum
Copy link
Member

@Akryum Akryum commented Dec 6, 2017

Fix #7191

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@Akryum Akryum requested a review from posva December 6, 2017 13:53
@@ -123,4 +123,32 @@ describe('Options data', () => {
}).$mount()
expect(vm.$el.innerHTML).toBe('<span>foo:1</span>')
})

it('should called with this when merged', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be

@yyx990803 yyx990803 merged commit bd4819e into vuejs:dev Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data method not called with this as argument when using mixins with data option
3 participants